Skip to content

London | JAN-ITP-26 | Kayanat Suleman | Sprint 3 | Alarm Clock App#969

Open
KayanatSuleman wants to merge 9 commits intoCodeYourFuture:mainfrom
KayanatSuleman:feature/alarm-clock
Open

London | JAN-ITP-26 | Kayanat Suleman | Sprint 3 | Alarm Clock App#969
KayanatSuleman wants to merge 9 commits intoCodeYourFuture:mainfrom
KayanatSuleman:feature/alarm-clock

Conversation

@KayanatSuleman
Copy link

@KayanatSuleman KayanatSuleman commented Feb 27, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Updated index.html title to “Alarm clock app”
  • Implemented setAlarm() logic in alarmclock.js
  • Added time formatting to display input in mm:ss
  • Implemented countdown functionality using setInterval
  • Updated heading every 1000ms while counting down
  • Triggered playAlarm() when timer reaches 00:00
  • Cleared interval when countdown completes to prevent negative values
  • Ensured all provided Jest tests pass

@KayanatSuleman KayanatSuleman added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Feb 27, 2026
@KayanatSuleman KayanatSuleman mentioned this pull request Feb 27, 2026
Open
10 tasks
A-O-Emmanuel
A-O-Emmanuel reviewed Feb 28, 2026
View reviewed changes
Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues with your alarm clock app:

  • When I click on the set alarm button, the timer starts counting backwards.
  • When I click on the set alarm button, without entrying any number in the input box, I don't get any alert message, instead the timer just starts counting backwards. I should not be able to set an alarm on an empty input box.
  • Your input box accepts negative numbers, it should not.

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 28, 2026
@KayanatSuleman
Copy link
Author

KayanatSuleman commented Mar 4, 2026

**A-O-Emmanuel **

Hi @A-O-Emmanuel Thank you for the review, I have made the necessary changes and the test are passing.

@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 4, 2026
A-O-Emmanuel
A-O-Emmanuel reviewed Mar 5, 2026
View reviewed changes
Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for you.

Sprint-3/alarmclock/alarmclock.js
let value = input.value

if (value === "") {
return;
Copy link

@A-O-Emmanuel A-O-Emmanuel Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of returning it will be better to show the user an appropriate message, can you think of a way to do that please.

Copy link
Author

@KayanatSuleman KayanatSuleman Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @A-O-Emmanuel, thank you for the review comments. I have updated the validation so that if the input field is empty, the app now displays a user message ("Please enter a number of seconds.") instead of returning silently. This prevents the timer from starting without valid input.

Sprint-3/alarmclock/alarmclock.js
let remainingSeconds = Number(value);

if (remainingSeconds <= 0 || isNaN(remainingSeconds)) {
return;
Copy link

@A-O-Emmanuel A-O-Emmanuel Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also instead of returning, it will be better you show the user an appropriate message, think of a way to do that.

Copy link
Author

@KayanatSuleman KayanatSuleman Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review comment. I have now updated the logic so that if the value is invalid (NaN) or less than or equal to zero, the app displays the message ("Please enter a positive number greater than 0.") rather than returning silently.

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 5, 2026
@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@A-O-Emmanuel A-O-Emmanuel A-O-Emmanuel left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Data-Groups The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KayanatSuleman @A-O-Emmanuel